From: Bryan Donlan <bdonlan@fushizen.net>
Date: Wed, 09 Apr 2008 01:30:01 GMT
Subject: [PATCH 5/8] test-lib.sh: Add a test_set_editor function to safely set $VISUAL
Message-ID: <1207704604-30393-5-git-send-email-bdonlan@fushizen.net>
In-Reply-To: <1207704604-30393-4-git-send-email-bdonlan@fushizen.net>

In particular, this function correctly handles cases where the pwd contains
spaces, quotes, and other troublesome metacharacters.

Signed-off-by: Bryan Donlan <bdonlan@fushizen.net>
---
 t/test-lib.sh |    9 +++++++++
 1 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/t/test-lib.sh b/t/test-lib.sh
index 17d4bc0..6f43376 100644
--- a/t/test-lib.sh
+++ b/t/test-lib.sh
@@ -160,6 +160,15 @@ die () {
 
 trap 'die' exit
 
+test_set_editor () {
+	# If the editor path contains a quote, just using VISUAL='"path"' isn't
+	# enough.
+	FAKE_EDITOR="$1"
+	export FAKE_EDITOR
+	VISUAL='"$FAKE_EDITOR"'
+	export VISUAL
+}
+
 test_tick () {
 	if test -z "${test_tick+set}"
 	then
-- 
1.5.5.8.gbbd98