From: Frank Lichtenheld Date: Fri, 14 Mar 2008 17:29:29 GMT Subject: [PATCH 3/4] Git.pm: Don't require repository instance for ident Message-ID: <1205515770-3424-4-git-send-email-frank@lichtenheld.de> In-Reply-To: <1205515770-3424-3-git-send-email-frank@lichtenheld.de> git var doesn't require to be called in a repository anymore, so don't require it either. Signed-off-by: Frank Lichtenheld --- perl/Git.pm | 12 ++++++------ 1 files changed, 6 insertions(+), 6 deletions(-) diff --git a/perl/Git.pm b/perl/Git.pm index 67b3749..2e7f896 100644 --- a/perl/Git.pm +++ b/perl/Git.pm @@ -632,15 +632,15 @@ The synopsis is like: "$name <$email>" eq ident_person($name); $time_tz =~ /^\d+ [+-]\d{4}$/; -Both methods must be called on a repository instance. - =cut sub ident { - my ($self, $type) = @_; + my ($self, $type) = _maybe_self(@_); my $identstr; if (lc $type eq lc 'committer' or lc $type eq lc 'author') { - $identstr = $self->command_oneline('var', 'GIT_'.uc($type).'_IDENT'); + my @cmd = ('var', 'GIT_'.uc($type).'_IDENT'); + unshift @cmd, $self if $self; + $identstr = command_oneline(@cmd); } else { $identstr = $type; } @@ -652,8 +652,8 @@ sub ident { } sub ident_person { - my ($self, @ident) = @_; - $#ident == 0 and @ident = $self->ident($ident[0]); + my ($self, @ident) = _maybe_self(@_); + $#ident == 0 and @ident = $self ? $self->ident($ident[0]) : ident($ident[0]); return "$ident[0] <$ident[1]>"; } -- 1.5.4.4