From: Martin Koegler Date: Mon, 18 Feb 2008 20:47:52 GMT Subject: [PATCH 01/12] read_object_with_reference: don't read beyond the buffer Message-ID: <12033676833730-git-send-email-mkoegler@auto.tuwien.ac.at> Signed-off-by: Martin Koegler --- sha1_file.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/sha1_file.c b/sha1_file.c index 4179949..d9da7c8 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -1943,7 +1943,8 @@ void *read_object_with_reference(const unsigned char *sha1, } ref_length = strlen(ref_type); - if (memcmp(buffer, ref_type, ref_length) || + if (ref_length + 40 > isize || + memcmp(buffer, ref_type, ref_length) || get_sha1_hex((char *) buffer + ref_length, actual_sha1)) { free(buffer); return NULL; -- 1.5.4.1.g96b77