From: Dragan Simic Date: Wed, 22 May 2024 19:03:20 GMT Subject: Re: [PATCH v2] add-patch: enforce only one-letter response to prompts Message-ID: <11abab810253d654119fab69adf44fab@manjaro.org> In-Reply-To: On 2024-05-22 18:23, Junio C Hamano wrote: > Dragan Simic writes: >> On 2024-05-22 01:20, Junio C Hamano wrote: >>> single-char mode, we may see 'qa' as a response to a prompt >> >> Perhaps s/single-char/single-character/ > > I shouldn't have been loose in the language. Rather, we should say > "single key mode", as the knob to control the feature is the > "interactive.singlekey" variable. Yes, "single-key mode" is better; "when interactive.singlekey is not enabled" may be even a bit better. Not worth a reroll, of course. >>> + /* 'g' takes a hunk number, '/' takes a regexp */ >>> + if (1 < s->answer.len && (ch != 'g' && ch != '/')) { >> >> To me, "s->answer.len > 1" would be much more readable, and >> I was surprised a bit to see the flipped variant. This made >> me curious; would you, please, let me know why do you prefer >> this form? > > "textual order should reflect actual order" (read CodingGuidelines). > > For more backstory, > > > https://lore.kernel.org/git/?q=%22textual+order%22+%22actual+order%22 That's exactly what I assumed, but frankly, in this particular case I really can't force myself, despite trying quite hard, into liking it. It's simply strange to me.