From: Michael Witten <mfwitten@mit.edu>
Date: Tue, 16 Oct 2007 07:27:18 GMT
Subject: Re: On Tabs and Spaces
Message-ID: <11F85069-1013-4685-9D56-C53F0F8231BF@MIT.EDU>
In-Reply-To: <20071016070421.GE13801@spearce.org>

On 16 Oct 2007, at 3:04:21 AM, Shawn O. Pearce wrote:

> The C code is all tabs, with the tabs set at 8 spaces, but the
> actual tab width isn't too important here as we never use the tab
> for alignment beyond the left indent.

Consider this from diff-lib.c:

> /* A file entry went away or appeared */
> static void diff_index_show_file(struct rev_info *revs,
> 				 const char *prefix,
> 				 struct cache_entry *ce,
> 				 unsigned char *sha1, unsigned int mode)
> {
> 	diff_addremove(&revs->diffopt, prefix[0], ntohl(mode),
> 		       sha1, ce->name, NULL);
> }

There are mixed tabs and spaces for alignment.

I suppose I'll be fine if I just set tab widths to 8.
But 8 spaces! Good Lord. ;-)

I really hate tabs.

Thanks,
Michael Witten