From: Kristian Høgsberg <krh@redhat.com>
Date: Mon, 17 Dec 2007 16:24:43 GMT
Subject: Re: [PATCH] Fix config lockfile handling.
Message-ID: <1197908683.8688.0.camel@hinata.boston.redhat.com>
In-Reply-To: <7vfxy5os60.fsf@gitster.siamese.dyndns.org>


On Fri, 2007-12-14 at 13:57 -0800, Junio C Hamano wrote:
> Kristian Høgsberg <krh@redhat.com> writes:
> 
> > When we commit or roll back the lock file the fd is automatically closed,
> > so don't do that again.
> 
> With your change, we do not check the return status from close(2)
> anymore, which means that we may have run out of diskspace without
> noticing and renamed the incomplete file into the real place.  Oops?

You're right of course.  Ok, so lets just stick with the current config
file handling for 1.5.4, it's not seriously broken.

Kristian