From: Kristian Høgsberg <krh@redhat.com>
Date: Fri, 02 Nov 2007 21:13:50 GMT
Subject: Re: [PATCH 1/4] Add testcase for ammending and fixing author in git commit.
Message-ID: <1194038030.25288.20.camel@hinata.boston.redhat.com>
In-Reply-To: <7vy7dg1kdg.fsf@gitster.siamese.dyndns.org>

On Fri, 2007-11-02 at 13:07 -0700, Junio C Hamano wrote:
> Kristian Høgsberg <krh@redhat.com> writes:
> 
> > Signed-off-by: Kristian Høgsberg <krh@redhat.com>
> > ---
> >  t/t7501-commit.sh |   10 ++++++++++
> >  1 files changed, 10 insertions(+), 0 deletions(-)
> >
> > diff --git a/t/t7501-commit.sh b/t/t7501-commit.sh
> > index b151b51..3f2112a 100644
> > --- a/t/t7501-commit.sh
> > +++ b/t/t7501-commit.sh
> > @@ -163,4 +163,14 @@ test_expect_success 'partial commit that involves removal (3)' '
> >  
> >  '
> >  
> > +author="The Real Author <someguy@his.email.org>"
> > +test_expect_success 'amend commit to fix author' '
> > +
> > +	git reset --hard
> > +	git cat-file -p HEAD | sed -e "s/author.*>/author $author/" > expected &&
> > +	git commit --amend --author="$author" &&
> > +	git cat-file -p HEAD > current &&
> > +	diff expected current
> > +	
> > +'
> >  test_done
> 
> This can't be right.  How are you ignoring the differences in
> committer dates?

t/test-lib.sh fixes GIT_COMMITTER_DATE so all commits have the date

committer C O Mitter <committer@example.com> 1112911993 -0700

unless you use test_tick.

> By the way, I _think_ git-commit.sh allows fixing author name/email
> without molesting the author timestamp (i.e. takes it from the
> amended commit).  That should probably be checked with the test
> as well.

You're right, I need to pick GIT_AUTHOR_DATE from the ammended commit.
Ok, I'll need to rewrite determine_author_info() a little bit.  I might
get an update patch out this weekend.

cheers,
Kristian