From: Kristian Høgsberg Date: Fri, 02 Nov 2007 16:16:12 GMT Subject: Re: [PATCH 3/4] Export launch_editor() and make it accept ':' as a no-op editor. Message-ID: <1194020172.25288.14.camel@hinata.boston.redhat.com> In-Reply-To: <472B466E.8070805@op5.se> On Fri, 2007-11-02 at 16:46 +0100, Andreas Ericsson wrote: > Kristian Høgsberg wrote: > > > > + if (!strcmp(editor, ":")) > > + return; > > + > > Doesn't this make the change in 2/4 superfluous? Yeah, but it's still a nice cleanup, I think. Kristian