From: Kristian Høgsberg Date: Wed, 05 Sep 2007 15:27:10 GMT Subject: Re: [RFC] Convert builin-mailinfo.c to use The Better String Library. Message-ID: <1189006030.20311.14.camel@hinata.boston.redhat.com> In-Reply-To: <46DDC500.5000606@etek.chalmers.se> On Tue, 2007-09-04 at 22:50 +0200, Lukas Sandström wrote: > Hi. > > This is an attempt to use "The Better String Library"[1] in builtin-mailinfo.c > > The patch doesn't pass all the tests in the testsuit yet, but I thought I'd > send it out so people can decide if they like how the code looks. > > I'm not sending a patch to add the library files at this time. I'll send > that patch when this patch is working. > > The changes required to make it pass the tests shouldn't be very large. Please, no. Let's not pull in a dependency for something as simple as a string library. How many distros have bstring pcakaged? The right version? Does it work on Windows? We already have strbuf.c, lets just consolidate the string manipulation code already in git under that interface. Kristian