From: Morten Welinder <mwelinder@gmail.com>
Date: Fri, 27 May 2005 14:02:56 GMT
Subject: Re: [PATCH] Fix ptrdiff_t vs. int
Message-ID: <118833cc05052707026a3dfedd@mail.gmail.com>
In-Reply-To: <42971EB4.2050403@oberhumer.com>

On 5/27/05, Markus F.X.J. Oberhumer <markus@oberhumer.com> wrote:
> This trivial patch fixes an obvious ptrdiff_t vs. int mismatch. Which
> makes we wonder why Linus isn't hitting this on his ppc64 - maybe it's
> time to start using -Werror...

The best time to start using -Werror is "never".  Different compilers
(and versions)
warn about different things, often affected by, say, optimization
switches.  Different
system headers contain things that one compiler or another will issue a warning
over.

Thus -Werror is solely for code that needs to work on one compiler, with one set
of switches, with one libc version, and specific versions of included libraries.

It is tempting to submit a patch to the gcc people making -Werror issue a
warning about the trouble using -Werror.

Morten