From: Keith Packard <keithp@keithp.com>
Date: Sun, 24 Jun 2007 21:31:07 GMT
Subject: Re: parsecvs fails even on simple input
Message-ID: <1182720667.13289.41.camel@neko.keithp.com>
In-Reply-To: <20070622113625.GD12473@rkagan.sw.ru>

On Fri, 2007-06-22 at 15:36 +0400, Roman Kagan wrote:

> The problem is the following: after that commit parsecvs tries to add
> objects to the git tree on its own via calls to libgit; however, in
> between it runs git-pack-objects.  Thus objects move to pack files
> without libgit being aware of it; this results in 'ivalid object'
> errors.

Sticking a call to reprepare_packed_git() after the pack creation fixes
this nicely.

>  Wouldn't it be better to teach parsecvs
> to speak git-fast-import language instead?

Avoiding fork/exec is rather important for parsecvs perforamance.

-- 
keith.packard@intel.com