From: Frank Lichtenheld Date: Sun, 17 Jun 2007 08:31:02 GMT Subject: [PATCH] cvsserver: always initialize state in argsplit() Message-ID: <11820690621003-git-send-email-frank@lichtenheld.de> In-Reply-To: <11820198064114-git-send-email-djk@tobit.co.uk> Other code assumes that this is initialized, so do it even if there were no arguments given. Signed-off-by: Dirk Koopman Signed-off-by: Frank Lichtenheld --- git-cvsserver.perl | 8 ++++---- 1 files changed, 4 insertions(+), 4 deletions(-) Hrm, sorry to Dirk for the double mail. This time actually send to the list and not to git@localhost ... diff --git a/git-cvsserver.perl b/git-cvsserver.perl index 5cbf27e..10aba50 100755 --- a/git-cvsserver.perl +++ b/git-cvsserver.perl @@ -1813,14 +1813,14 @@ sub req_annotate # the second is $state->{files} which is everything after it. sub argsplit { - return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" ); - - my $type = shift; - $state->{args} = []; $state->{files} = []; $state->{opt} = {}; + return unless( defined($state->{arguments}) and ref $state->{arguments} eq "ARRAY" ); + + my $type = shift; + if ( defined($type) ) { my $opt = {}; -- 1.5.2.1