From: Derrick Stolee Date: Fri, 15 Jun 2018 14:35:00 GMT Subject: Re: [PATCH 0/8] Delete unused methods in EWAH bitmap Message-ID: <117a06ba-9ea1-ca7e-7967-e92db0e27c38@gmail.com> In-Reply-To: <20180615143018.170686-1-dstolee@microsoft.com> On 6/15/2018 10:30 AM, Derrick Stolee wrote: > The EWAH bitmap code includes several logical operations that are > important for a general-purpose bitmap library. However, Git only > uses the XOR operation for storing deltas between reachability > bitmaps. This means that we can delete the following unused methods: > > * ewah_and() > * ewah_and_not() > * ewah_not() > * ewah_or() > * ewah_serialize() > * ewah_serialize_native() > > We can also delete the unused methods bitmap_clear() and > bitmap_each_bit(). > > Derrick Stolee (8): > ewah/bitmap.c: delete unused 'bitmap_clear()' > ewah/bitmap.c: delete unused 'bitmap_each_bit()' > ewah_bitmap: delete unused 'ewah_and()' > ewah_bitmap: delete unused 'ewah_and_not()' > ewah_bitmap: delete unused 'ewah_not()' > ewah_bitmap: delete unused 'ewah_or()' > ewah_io: delete unused 'ewah_serialize()' > ewah_io: delete unused 'ewah_serialize_native()' > > ewah/bitmap.c | 32 ------- > ewah/ewah_bitmap.c | 229 --------------------------------------------- > ewah/ewah_io.c | 36 ------- > ewah/ewok.h | 24 ----- > 4 files changed, 321 deletions(-) > > > base-commit: fc54c1af3ec09bab8b8ea09768c2da4069b7f53e Responders to this thread beware: I accidentally added an extra letter in Peff's email address, so be careful with reply-all. Sorry! -Stolee