From: Pierre Habouzit Date: Wed, 23 Aug 2006 09:17:55 GMT Subject: [PATCH] Fix a comparison bug in diff-delta.c Message-ID: <1156324675415-git-send-email-madcoder@debian.org> (1 << i) < hspace is compared in the `int` space rather that in the unsigned one. the result will be wrong if hspace is between 0x40000000 and 0x80000000. Signed-off-by: Pierre Habouzit --- This is a replacement for <1156300368160-git-send-email-madcoder@debian.org> avoiding the ugly cast, and using 1u instead. diff-delta.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/diff-delta.c b/diff-delta.c index 7da9205..51e2e56 100644 --- a/diff-delta.c +++ b/diff-delta.c @@ -152,7 +152,7 @@ struct delta_index * create_delta_index( initialization in create_delta(). */ entries = (bufsize - 1) / RABIN_WINDOW; hsize = entries / 4; - for (i = 4; (1 << i) < hsize && i < 31; i++); + for (i = 4; (1u << i) < hsize && i < 31; i++); hsize = 1 << i; hmask = hsize - 1; -- 1.4.1.1