From: Jakub Narebski Date: Tue, 22 Aug 2006 17:05:24 GMT Subject: [PATCH 1/2] gitweb: Drop the href() params which keys are not in %mapping Message-ID: <11562663253739-git-send-email-jnareb@gmail.com> In-Reply-To: <200608211739.32993.jnareb@gmail.com> If someone would enter parameter name incorrectly, and some key of %params is not found in %mapping hash, the parameter is now ignored. Change introduced by Martin Waitz in commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103 tried to do that, but it left empty value and there was doubled ";;" in returned string. Signed-off-by: Jakub Narebski Signed-off-by: Junio C Hamano --- gitweb/gitweb.perl | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 063735d..89ef5e7 100755 --- a/gitweb/gitweb.perl +++ b/gitweb/gitweb.perl @@ -278,7 +278,7 @@ sub href(%) { my $href = "$my_uri?"; $href .= esc_param( join(";", map { - "$mapping{$_}=$params{$_}" if defined $params{$_} + defined $params{$_} ? "$mapping{$_}=$params{$_}" : () } keys %params ) ); -- 1.4.1.1