From: Rene Scharfe Date: Thu, 10 Aug 2006 15:02:35 GMT Subject: [PATCH 6/9] git-verify-pack: free pack after use and a cleanup Message-ID: <11552221582064-git-send-email-rene.scharfe@lsrfire.ath.cx> In-Reply-To: <11552221582769-git-send-email-rene.scharfe@lsrfire.ath.cx> Plug memory leak in verify_one_pack() by freeing the struct packed_git we got from add_packed_git(). Also rename g to pack and pull an assignment out of an if statement while we're at it. Signed-off-by: Rene Scharfe --- verify-pack.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/verify-pack.c b/verify-pack.c index 1dcef52..c7bed1e 100644 --- a/verify-pack.c +++ b/verify-pack.c @@ -5,7 +5,8 @@ static int verify_one_pack(const char *p { char arg[PATH_MAX]; int len; - struct packed_git *g; + struct packed_git *pack; + int err; len = strlcpy(arg, path, PATH_MAX); if (len >= PATH_MAX) @@ -25,10 +26,14 @@ static int verify_one_pack(const char *p len += 4; } - if (!(g = add_packed_git(arg, len, 1))) + pack = add_packed_git(arg, len, 1); + if (!pack) return error("packfile %s not found.", arg); - return verify_pack(g, verbose); + err = verify_pack(pack, verbose); + free(pack); + + return err; } static const char verify_pack_usage[] = "git-verify-pack [-v] ..."; -- 1.4.2.rc2.g822a