From: David Woodhouse Date: Mon, 08 May 2006 23:44:36 GMT Subject: Re: git-feed-mail-list.sh Message-ID: <1147131877.2694.37.camel@shinybook.infradead.org> In-Reply-To: <7vmzdy9zl2.fsf@assigned-by-dhcp.cox.net> On Wed, 2006-05-03 at 21:35 -0700, Junio C Hamano wrote: > If you were to do bashism local, don't you want to also localize > other variables like key, SUBHEX, NEWSUB,...? > > It may make sense to enhance format-patch to do the Q encoding, > so that you do not have to do this part by hand... Yes, that would be useful. We should perhaps to the From: and To: headers too. Here's my current version (thanks for the feedback)... The remaining problem is that the invocation of 'date' doesn't work with new versions of coreutils. This... date=(${rest#*> }) sec=${date[0]}; tz=${date[1]} dtz=${tz/+/+ }; dtz=${dtz/-/- } pdate="$(date -Rud "1970-01-01 UTC + $sec sec $dtz" 2>/dev/null)" ... doesn't work any more on FC-5, because: $ date -Rud '1970-01-01 UTC + 1147104611 sec + 0100' date: invalid date `1970-01-01 UTC + 1147104611 sec + 0100' -- dwmw2