From: Derrick Stolee <stolee@gmail.com>
Date: Wed, 06 Oct 2021 20:41:26 GMT
Subject: Re: [PATCH 0/5] cat-file replace handling and optimization
Message-ID: <1139fb26-5b93-0181-f908-6f9d7449bc62@gmail.com>
In-Reply-To: <YVy1sx8Xb1xMLFQT@coredump.intra.peff.net>

On 10/5/2021 4:29 PM, Jeff King wrote:
> This started as an optimization to have cat-file use the pack/offset
> info it gets during --batch-all-objects to avoid extra object lookups.
> And that does happen in the final patch.
> 
> But there was an interesting interaction with replace refs there, which
> led me to patch 3.
> 
> The other patches are relevant prep/cleanup.
> 
>   [1/5]: t1006: clean up broken objects
>   [2/5]: cat-file: mention --unordered along with --batch-all-objects
>   [3/5]: cat-file: disable refs/replace with --batch-all-objects
>   [4/5]: cat-file: split ordered/unordered batch-all-objects callbacks
>   [5/5]: cat-file: use packed_object_info() for --batch-all-objects

I took a close read through this series and it was easy to understand.

LGTM. Nice ~2x speedup in patch 5.

Thanks,
-Stolee