From: Pavel Roskin Date: Wed, 21 Dec 2005 21:47:21 GMT Subject: Re: [PATCH] off-by-one bugs found by valgrind Message-ID: <1135201641.15567.7.camel@dv> In-Reply-To: <43A9C654.2010009@zytor.com> On Wed, 2005-12-21 at 13:17 -0800, H. Peter Anvin wrote: > >>quote_c_style_counted() in quote.c uses a dangerous construct, when a > >>variable is incremented once and used twice in the same expression. > > > > Sorry, I do not follow you. Isn't && a sequence point? The patch is right, but my comment was wrong, sorry. The actual problem detected by valgrind is that sp is dereferenced before it's checked for the upper boundary. So, if e.g. namelen is 6, the code reads name[6] into ch and then leaves the loop. > && is a sequence point. The code is techically fine, but it's harder > than necessary to read. That alone should be a good reason to apply this patch. -- Regards, Pavel Roskin