From: Pavel Roskin Date: Fri, 28 Oct 2005 22:45:03 GMT Subject: Re: gitk shows an empty line between "Comments" and changed files Message-ID: <1130539503.10531.43.camel@dv> In-Reply-To: <7v4q72xavz.fsf@assigned-by-dhcp.cox.net> Hi, Junio! On Fri, 2005-10-28 at 02:13 -0700, Junio C Hamano wrote: > Pavel Roskin writes: > > > git-patch-id is only used by git-cherry. git-cherry writes the second > > SHA1 to some files in a temporary directory, but it never reads those > > files, it only checks that they exist. > > I do not oppose dropping the commit-id line from the default > output, but having it optionally available would be useful in > one application. Somebody _could_ write a tool that does > something like: > > git-rev-list ^$old_head $new_head | > git-diff-tree -p -m --stdin --with-commit-ids | > git-patch-id Sounds good. Perhaps the commit IDs should have a prefix identifying them. Another approach would be to use something slightly more elaborate than a pipe. If I understand correctly, the commit ID would be already known from the git-rev-list output. Passing commit IDs through patch-id without actually doing anything with them seems non-elegant. Maybe we could teach git-patch-id (or another script) to get patches by commit-id instead of using stdin? -- Regards, Pavel Roskin