From: David Mansfield <david@cobite.com>
Date: Fri, 30 Sep 2005 13:54:45 GMT
Subject: Re: [PATCH] Added an option to cvsimport to specify email domain
Message-ID: <1128088485.30421.80.camel@gandalf.cobite.com>
In-Reply-To: <200509301219.42087.snake@penza-gsm.ru>

On Fri, 2005-09-30 at 12:19 +0400, Alexey Nezhdanov wrote:
> On Tuesday 27, September 2005 16:54 David Mansfield wrote:
> > On Tue, 2005-09-27 at 08:34 +0400, Alexey Nezhdanov wrote:
> > > (Re-post. Sorry for any inconvenience.)
> > >
> > > On September 14, 2005 23:34 Petr Baudis wrote:
> > > > Dear diary, on Wed, Sep 07, 2005 at 09:18:03PM CEST, I got a letter
> > > > where Junio C Hamano <junkio@cox.net> told me that...
> > > >
> > > > > David K?.A?Negedal <davidk@lysator.liu.se> writes:
> > > > > > The authorship info in commits created by git-cvsimport-script
> > > > > > only contains the username of the CVS committer.  This patch
> > > > > > adds a flag -e <domain> to git-cvsimport-script that makes it
> > > > > > possible to specify an email domain that is added to all email
> > > > > > addresses in the commit "author" and "committer" fields.
> > > > > >
> > > > > > ---
> > > > > > I have stopped using cvsimport, because cvsps seems to produce bad
> > > > > > output on the repository I'm using it with, but I had already
> > > > > > prepared this patch.
> > > > >
> > > > > Hmph.  One reason the original implementation did not do this is
> > > > > because Linus and other people wanted to have a repeatability,
> > > > > so making this an optional thing is good, but if we go this
> > > > > route, I think if it would be nicer to have a --author-map
> > > > > option that lets you feed a list of:
> > > > >
> > > > >     <author> ==> "A U Thor <author@author.dom>"
> > > > >
> > > > > mappings, instead of a single -e, which essentially does not add
> > > > > much information to the result.
> > > > >
> > > > > I take that your oob comment indicates that you do not have much
> > > > > incentive/inclination to further hack on this, so I am not
> > > > > asking you to do the above even if you find my suggestion
> > > > > worthwhile.
> > > >
> > > > Various tools use CVSROOT/users to map usernames to realname <email>.
> > > > I actually wanted to send a patch, looked at the cvsimport script and
> > > > got totally scared away (at least for now)... ;-)
> > >
> > > git uses cvsps output to determine authorship. Do you think if this
> > > problem should be solved on cvsps side? It should be relatively easy
> > > IMHO. David, can you add another key to output CVSROOT/users mapping
> > > result instead of usernames if available?
> >
> > I apologize that I probably won't have time to look at this right now...
> >
> > David
> 
> Hello. I have improved my patch and tested it with git-cvsimport-script.
> cvsps works as intended so I hope that you, David will accept this patch. You can find it here:
> http://www.penza-gsm.ru/snake/use_CVSROOT_users.patch
> 
> Though git-cvsimport-script not works as good as I wanted. It confuses with cvsps output like
> Author: Alexey Nezhdanov <snakeru at users.sourceforge.net>
> and converts it to something like
> Alexey Nezhdanov snakeru at users.sourceforge.net <Alexey Nezhdanov snakeru at users.sourceforge.net>
> 
> Unfortunately I do not know perl so I can not write a patch for git-cvsimport-script.
> So I asking you, Matthias, to help with this or may somebody on this list can do it instead.
> 

Cool. I'll definitely take a look.  Thanks for taking the time.

David