From: Martin Schlemmer Date: Fri, 22 Apr 2005 17:25:45 GMT Subject: Re: [patch] fixup GECOS handling Message-ID: <1114190745.29271.39.camel@nosferatu.lan> In-Reply-To: <20050422171818.GE7173@pasky.ji.cz> On Fri, 2005-04-22 at 19:18 +0200, Petr Baudis wrote: > Dear diary, on Fri, Apr 22, 2005 at 06:58:25PM CEST, I got a letter > where Martin Schlemmer told me that... > > Meaning, if they use a ',' in one of the fields (and it is a linux > > system with the chfn most probably from the shadow package), then they > > are looking for trouble. The only reason I added the ';' was because > > somebody said whatever OS used it instead of a ','. > > What about just swapping the two tests so that ; is cut off and , only > when no ; is around? > Actually, maybe just leave it. Its not a train smash, and in theory on linux ';' is a valid char in the gecos. -- Martin Schlemmer