From: Remi Galan Alfonso <remi.galan-alfonso@ensimag.grenoble-inp.fr>
Date: Wed, 03 Jun 2015 20:09:10 GMT
Subject: Re: [PATCH/RFCv2 2/2] git rebase -i: warn about removed commits
Message-ID: <1105867541.79324.1433362150592.JavaMail.zimbra@ensimag.grenoble-inp.fr>
In-Reply-To: <CAPig+cR=xKy-WSZSRgC8UbEbyY+=t7yDZo3O-2GquWXWWPrGVA@mail.gmail.com>

Eric Sunshine <sunshine@sunshineco.com> writes:

> > +test_expect_success 'rebase -i respects rebase.missingCommitsCheck=ignore' '
> > +       test_config rebase.missingCommitsCheck ignore &&
> > +       test_when_finished "git checkout master &&
> > +               git branch -D tmp2" &&
> 
> Strange indentation.

Considering that 'git branch -D tmp2' is a part of test_when_finished,
I wasn't sure of how it was supposed to be indented, so I did it this
way to show that it was still within test_when_finished and not a
separate command.
> 	test_when_finished "git checkout master &&
> 	git branch -D tmp2" &&
Doesn't seem as clear, especially if you quickly read the lines.

For now, I have removed the tab.
Also the other points have been corrected.

Thank you,
Rémi