From: Rob Shearman <robertshearman@gmail.com>
Date: Wed, 09 Jul 2008 21:24:27 GMT
Subject: Re: [PATCH 2/4] git-imap-send: Add support for SSL.
Message-ID: <1096648c0807091424g1e10d0ccrae0be929ec428b89@mail.gmail.com>
In-Reply-To: <1215616484.3053.6.camel@josh-work.beaverton.ibm.com>

2008/7/9 Josh Triplett <josht@linux.vnet.ibm.com>:
> On Tue, 2008-07-08 at 23:18 +0100, Robert Shearman wrote:
>> --- a/Documentation/git-imap-send.txt
>> +++ b/Documentation/git-imap-send.txt
>> @@ -37,10 +37,11 @@ configuration file (shown with examples):
>>      Tunnel = "ssh -q user@server.com /usr/bin/imapd ./Maildir 2> /dev/null"
>>
>>  [imap]
>> -    Host = imap.server.com
>> +    Host = imaps://imap.example.com
>>      User = bob
>>      Pass = pwd
>> -    Port = 143
>> +    Port = 993
>> +    sslverify = false
> [...]
>> @@ -1280,6 +1411,8 @@ git_imap_config(const char *key, const char *val, void *cb)
>>               server.port = git_config_int( key, val );
>>       else if (!strcmp( "tunnel", key ))
>>               server.tunnel = xstrdup( val );
>> +     else if (!strcmp( "ssl_verify", key ))
>> +             server.ssl_verify = git_config_bool( key, val );
>
> The example and the code disagree on the name of the
> sslverify/ssl_verify option.

I wouldn't exactly call it "disagree". The config variable is limited
by not allowing underscores, whereas the C language does allow them.

> Also, ssl_verify needs explanation.

See patch 4/4.

-- 
Rob Shearman