From: Rob Shearman <robertshearman@gmail.com>
Date: Mon, 02 Jun 2008 08:18:09 GMT
Subject: Re: [PATCH] git-imap-send: Allow the program to be run from subdirectories of a git tree.
Message-ID: <1096648c0806020118i1d990affn17af29651e60b13b@mail.gmail.com>
In-Reply-To: <20080601220410.GD29404@genesis.frugalware.org>

2008/6/1 Miklos Vajna <vmiklos@frugalware.org>:
> On Sun, Jun 01, 2008 at 04:28:44PM +0100, Rob Shearman <robertshearman@gmail.com> wrote:
>> +     setup_git_directory_gently( NULL );
>>       git_config(git_imap_config, NULL);
>
> I know this is just about cosmetics, but the style of the rest of the
> code would suggest using
>
>        setup_git_directory_gently(NULL);
>
> not
>
>        setup_git_directory_gently( NULL );

This isn't my normal coding style - I was trying to match the coding
style to the rest of the file. Only the subsequent line to my added
line uses the "func(arg)" style instead of the "func( arg )" style and
that line was changed to the former very recently.

A patch to fix the style of the call to git_config could be done
separately to this one.

-- 
Rob Shearman