From: Phillip Wood Date: Thu, 18 May 2023 09:58:26 GMT Subject: Re: [PATCH v2] sequencer: beautify subject of reverts of reverts Message-ID: <10523968-0f02-f483-69c4-24e62e839f70@gmail.com> In-Reply-To: On 17/05/2023 18:02, Oswald Buddenhagen wrote: > On Wed, May 17, 2023 at 12:20:03PM +0100, Phillip Wood wrote: >> I'm saying that reverting a commit with a subject line >> >>     Revert "Revert "Revert some subject"" >> >> should result in the new commit having the subject >> >>     Revert "Revert "Revert "Revert some subject""" >> >> (i.e. at that point we stop trying to be clever) rather than >> >>     Revert "Reapply "Revert some subject"" >> > right. > how about filing that under GIGO and extending the comment? > i mean, when you actually run into this situation, you should be > re-thinking your life choices rather than stressing about git producing > a somewhat suboptimal commit message template ... Given that it is simple to handle this case and Junio is expecting a re-roll of this topic[1] then I think it would be worth just adding those three lines. Best Wishes Phillip [1] https://lore.kernel.org/git/xmqqa5y3ssss.fsf@gitster.g/ > regards, > ossi