From: Jean-Noël Avila Date: Wed, 15 Mar 2017 08:11:19 GMT Subject: Re: [PATCH] l10n: add framework for localizing the manpages Message-ID: <103dec84-b274-0a81-fa9b-bf29afd988d9@free.fr> In-Reply-To: Le 14/03/2017 à 22:00, Ævar Arnfjörð Bjarmason a écrit : > On Mon, Mar 13, 2017 at 1:01 AM, Junio C Hamano wrote: >> Jean-Noel Avila writes: > Jean: Comments on the patch: > > - Firstly thanks for working on this. When I hacked up the initial po > support in v1.7.8-rc2-1-g5e9637c629 I always meant to try out po4a, > but never got around to it. It's much easier than I thought. Well, that's only the simplest setup I could come up with :-). I'm discovering the tool and it seems that can go quite hairy, depending on where we want to go. > - Consider submitting a more minimal patch that doesn't have the giant > fr.po (or just some minor cut version) as the tip of the series, to > make this easier to review OK. Will split in po4a.conf + Makefile changes, then pot and po files. The point is that as long as the po files are not translated at a minimum level, po4a does not generate the target files. Right now, the threshold is 80% of translated strings (no fuzzy). > - The git-add.txt file is hardcoded in po4a.conf, won't this file need > to be generated in some final version of this series? If all the translation string are harvested automatically from the source files, the resulting po file will be huge. For the moment, I prefered to manually select the files and check that po4a behaves correctly.