From: Thomas Ackermann Date: Sun, 07 Oct 2012 08:01:00 GMT Subject: Aw: Re: [Patch 1/5] Fix some asciidoc layout problems Message-ID: <1013292233.101229.1349596860911.JavaMail.ngmail@webmail23.arcor-online.net> In-Reply-To: <20121006191009.GB3644@sigill.intra.peff.net> Making the dashed lines longer was unnecessary and I will remove this. There were in general the following "layout problems" I encountered while trying to create git-doc.pdf: - Wrong sectioning syntax (e.g. "===" instead of "---") - Left-over shell scripting commands (in some release notes files) - Over-long lines which caused very wide right margins in the resulting pdf The later is the case here and I tried to fix this by either splitting the offending line in several lines or removing as much spaces as possible. I will be more specific about these things in my commit messages. ----- Original Nachricht ---- Von: Jeff King An: Junio C Hamano Datum: 06.10.2012 21:10 Betreff: Re: [Patch 1/5] Fix some asciidoc layout problems > On Sat, Oct 06, 2012 at 11:39:13AM -0700, Junio C Hamano wrote: > > > Thomas Ackermann writes: > > > > > Signed-off-by: Thomas Ackermann > > > --- > > > Documentation/git-bisect-lk2009.txt | 12 ++++++------ > > > Documentation/git-fetch-pack.txt | 5 ++++- > > > 2 files changed, 10 insertions(+), 7 deletions(-) > > > > You didn't say what "layout problem" you are fixing, or what the > > approach you took to "fix" it. From the patch, I can guess that the > > latter is to lengthen the lines that surround the displayed examples, > > but as far as I know and can tell, the existing ones are long enough > > so I cannot tell why you needed such a change to the source in the > > first place. > > > > A better explanation, please? > > I had the same question. Also, some of the lines convert tabs in literal > output into spaces, which is actively wrong (or maybe they were > converted already to spaces in the current code, but they should at > least align with 8-space tabstops): > > > > -:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 > 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile > > > +:100644 100644 5cf8258195331a4dbdddff08b8d68642638eea57 > 4492984efc09ab72ff6219a7bc21fb6a957c4cd5 M Makefile > > -Peff > --- Thomas