From: Brandon Casey Date: Thu, 16 Oct 2008 15:21:24 GMT Subject: Re: What's in git.git (Oct 2008, #03; Tue, 14) Message-ID: <0my5lujnbpdG6sxrffMExwukINu2tasxBSH0E0xYQoe6y5yyFL0LNA@cipher.nrlssc.navy.mil> In-Reply-To: <20081016100805.GA20762@sigill.intra.peff.net> Jeff King wrote: > On Wed, Oct 15, 2008 at 10:35:30AM -0500, Brandon Casey wrote: > >> 2) Do we want to stick with compat/regex on >> >> Darwin: Arjen >> FreeBSD: Jeff >> AIX: Mike >> >> now that the builtin funcname patterns have been converted to Extended >> Regular Expressions? > > t4018 passes without compat/regex on FreeBSD. Is that a sufficient test? I think so. t4018 makes sure all the patterns compile, and includes Arjen's test for appropriate handling of the alternation operator. Darwin, anyone? -brandon