From: Jeff Hostetler <git@jeffhostetler.com>
Date: Tue, 05 Nov 2019 15:00:09 GMT
Subject: Re: [PATCH] trace2: add dots directly to strbuf in perf_fmt_prepare()
Message-ID: <0fae18b6-dd98-f7df-d2a9-cfdc34916686@jeffhostetler.com>
In-Reply-To: <c4237b45-6faf-c1fc-eb13-b6c71b7fb6ef@web.de>



On 11/4/2019 2:27 PM, René Scharfe wrote:
> The initialization function of the Trace2 performance format target sets
> aside a stash of dots for indenting output.  Get rid of it and use
> strbuf_addchars() to provide dots on demand instead.  This shortens the
> code, gets rid of a small heap allocation and is a bit more efficient.
> 
> Signed-off-by: René Scharfe <l.s.r@web.de>

Looks good!
Thanks for simplifying my otherwise convoluted code.
Jeff