From: Kristoffer Haugsbakk <code@khaugsbakk.name>
Date: Fri, 19 Apr 2024 13:43:10 GMT
Subject: Re: [PATCH] format-patch: ensure that --rfc and -k are mutually exclusive
Message-ID: <0d584b86-0b48-4e7f-b81c-fdb672dac98b@app.fastmail.com>
In-Reply-To: <71d195c248879e7c46fac0e84c6b0a8aa90bd2c2.1713488563.git.dsimic@manjaro.org>

On Fri, Apr 19, 2024, at 03:05, Dragan Simic wrote:
> Fix a bug that allows the "--rfc" and "-k" options to be specified together
> when "git format-patch" is executed, which was introduced in the commit
> e0d7db7423a9 ("format-patch: --rfc honors what --subject-prefix sets").
>
> Add a couple of additional tests to t4014, to cover additional cases of
> the mutual exclusivity between different "git format-patch" options.
>
> Signed-off-by: Dragan Simic <dsimic@manjaro.org>

Looks good to me FWIW. Also very good description of the changes from
the previous version to this one.