From: Derrick Stolee <derrickstolee@github.com>
Date: Mon, 16 May 2022 20:49:23 GMT
Subject: Re: [PATCH 1/8] sparse-index: create expand_to_pattern_list()
Message-ID: <0d4cf56a-83b6-c7d2-b0b8-a5a5e5d0ccfd@github.com>
In-Reply-To: <12df1777-9f02-ca6f-7d17-57aebe25d06c@github.com>

On 5/16/2022 4:36 PM, Victoria Dye wrote:
> Derrick Stolee via GitGitGadget wrote:

>> -void ensure_full_index(struct index_state *istate)
>> +void expand_to_pattern_list(struct index_state *istate,
>> +			      struct pattern_list *pl)
> 
> Hyper-nit: I don't think this is aligned (it's probably not worth fixing
> unless you end up rerolling for something else).

You're right. When I saw this I thought it was just the
"off by one" issue when patches have a "+" in the beginning,
but it's actually the backwards order. Thanks for catching it.

-Stolee