From: Johannes Schindelin <johannes.schindelin@gmx.de>
Date: Tue, 13 Oct 2015 11:48:16 GMT
Subject: Re: [PATCH 0/2] Reinstate the helpful message when `git pull --rebase` fails
Message-ID: <0d0983480d85118291a058dcd3ef727d@dscho.org>
In-Reply-To: <xmqqio6bltkq.fsf@gitster.mtv.corp.google.com>

Hi Junio,

On 2015-10-12 22:28, Junio C Hamano wrote:
> Johannes Schindelin <johannes.schindelin@gmx.de> writes:
> 
>>> I think the most sensible regression fix as the first step at this
>>> point is to call it as a separate process, just like the code calls
>>> "apply" as a separate process for each patch.  Optimization can come
>>> later when it is shown that it matters---we need to regain
>>> correctness first.
>>
>> I fear that you might underestimate the finality of this "first
>> step". If you reintroduce that separate process, not only is it a
>> performance regression, but could we really realistically expect any
>> further steps to happen after that? I do not think so.
>> ...
>> For the above reasons, I respectfully remain convinced that
>> reintroducing the separate process would be a mistake.
> 
> I am not saying we should forever do run_command() going forward.

Fine, I will stop arguing about this and go back grumble in my corner.

Ciao,
Dscho