From: Jacob Keller <jacob.e.keller@intel.com>
Date: Mon, 13 Oct 2025 23:14:45 GMT
Subject: Re: [PATCH] diff --no-index: fix logic for paths ending in '/'
Message-ID: <0cc105dd-717a-49d1-96ca-e884e7d9f157@intel.com>
In-Reply-To: <xmqqjz12ag5j.fsf@gitster.g>



On 10/10/2025 9:13 AM, Junio C Hamano wrote:
> Jacob Keller <jacob.e.keller@intel.com> writes:
> 
>>> You can squash this in, or I can do so myself if you like, if this
>>> is the only change that is required.
>>>
>>>  diff-no-index.c | 2 ++
>>>  1 file changed, 2 insertions(+)
>>>
>>> diff --git c/diff-no-index.c w/diff-no-index.c
>>> index c70f82b805..f320424f05 100644
>>> --- c/diff-no-index.c
>>> +++ w/diff-no-index.c
>>> @@ -436,6 +436,8 @@ int diff_no_index(struct rev_info *revs, const struct git_hash_algo *algop,
>>>  	for (i = 0; i < ARRAY_SIZE(to_free); i++)
>>>  		free(to_free[i]);
>>>  	strbuf_release(&replacement);
>>> +	strbuf_release(&ps_match1);
>>> +	strbuf_release(&ps_match2);
>>>  	if (ps)
>>>  		clear_pathspec(ps);
>>>  	return ret;
>>
>> Please squash this in. I'll fix it if we need a v2 otherwise.
> 
> Since this exchange things have gone quiet, so shall we declare
> victory and merge it down to 'next' and then eventually to 'master'?
> 
> Thanks.

That would be my preference. I haven't seen any other reports or
comments about this since the v1 besides the missing strbuf release.

Thanks,
Jake