From: Jeff Hostetler Date: Tue, 01 Mar 2022 19:37:16 GMT Subject: Re: [PATCH 04/23] t/helper/fsmonitor-client: create stress test Message-ID: <0baa2939-bf3c-b08b-2cfc-5a96be760b1c@jeffhostetler.com> In-Reply-To: On 2/24/22 9:58 AM, Derrick Stolee wrote: > On 2/15/2022 10:59 AM, Jeff Hostetler via GitGitGadget wrote: >> From: Jeff Hostetler >> >> Create a stress test to hammer on the fsmonitor daemon. >> Create a client-side thread pool of n threads and have >> each of them make m requests as fast as they can. >> >> NEEDSWORK: This is just the client-side thread pool and >> is useful for interactive testing and experimentation. >> We need to add a script test to drive this. > > I haven't gotten far enough in the series to know if you > _do_ use this in a test eventually. If so, this NEEDSWORK > could be replaced with a mention of a future change. Right. I mainly use this test helper to hammer on the daemon during interactive tests. I don't have a script to actually use. I'm currently not sure what that would look like given our test script framework. > >> + /* >> + * TODO Decide if/when to return an error or call die(). >> + */ >> + return 0; > > This TODO could be cleaned up. good catch. thanks! Jeff