From: Johannes Sixt Date: Tue, 26 Sep 2017 19:46:50 GMT Subject: Re: [PATCH] t7406: submodule..update command must not be run from .gitmodules Message-ID: <0b69c0b0-6246-2428-b4b0-bb3ef3cb5ae7@kdbg.org> In-Reply-To: <20170926185413.21209-1-sbeller@google.com> Am 26.09.2017 um 20:54 schrieb Stefan Beller: > +test_expect_success 'submodule update - command in .gitmodules is ignored' ' > + test_when_finished "git -C super reset --hard HEAD^" && > + > + git -C super config -f .gitmodules submodule.submodule.update "!false" && > + git -C super commit -a -m "add command to .gitmodules file" && > + git -C super/submodule reset --hard $submodulesha1^ && > + git -C super submodule update submodule && > + test_path_is_missing bad This test for a missing file is certainly a remnant from the previous iteration, isn't it? -- Hannes