From: Jonathan Tan <jonathantanmy@google.com>
Date: Tue, 01 Nov 2016 20:53:47 GMT
Subject: Re: [PATCH v2 1/5] trailer: be stricter in parsing separators
Message-ID: <0b3e70fe-5e1f-7aaa-4c3d-88f30cb15008@google.com>
In-Reply-To: <xmqqr36vndgn.fsf@gitster.mtv.corp.google.com>

On 11/01/2016 01:37 PM, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> Jonathan Tan <jonathantanmy@google.com> writes:
>>
>>> Currently, a line is interpreted to be a trailer line if it contains a
>>> separator. Make parsing stricter by requiring the text on the left of
>>> the separator, if not the empty string, to be of the "<token><optional
>>> whitespace>" form.
>>
>> Hmph.  The optional whitespace is to allow for what kind of line?
>>
>> It is not for "Signed off by:" that is a misspelt "Signed-off-by:";
>> it may not hurt but I do not think of a case that would be useful
>> offhand.

This is to allow trailers of the form "Fix #42" (mentioned in the 
git-interpret-trailers documentation and also in the test).

> Other than this "Hmph" (which is not an objection---just something
> that the reviewer did not understand), the rest looked good to me.
>
> Will re-queue.
>
> Thanks.

Thanks!