From: Kjetil Barvik Date: Mon, 09 Feb 2009 20:54:52 GMT Subject: [PATCH v4 8/9] show_patch_diff(): remove a call to fstat() Message-ID: <0b2bf9500731f079b5e711a8ee7da692da1ee865.1234211595.git.barvik@broadpark.no> In-Reply-To: Currently inside show_patch_diff() we have an fstat() call after an ok lstat() call. Since before the call to fstat() we have already tested for the link case with S_ISLNK(), the fstat() can be removed. Signed-off-by: Kjetil Barvik --- combine-diff.c | 4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/combine-diff.c b/combine-diff.c index bccc018..4300319 100644 --- a/combine-diff.c +++ b/combine-diff.c @@ -713,9 +713,7 @@ static void show_patch_diff(struct combine_diff_path *elem, int num_parent, result_size = buf.len; result = strbuf_detach(&buf, NULL); elem->mode = canon_mode(st.st_mode); - } - else if (0 <= (fd = open(elem->path, O_RDONLY)) && - !fstat(fd, &st)) { + } else if (0 <= (fd = open(elem->path, O_RDONLY))) { size_t len = xsize_t(st.st_size); ssize_t done; int is_file, i; -- 1.6.1.349.g99fa5