From: Stefan Haller <stefan@haller-berlin.de>
Date: Wed, 14 Oct 2020 10:27:23 GMT
Subject: Re: [PATCH] git-gui: Make usettk off by default on Mac OS X
Message-ID: <0aef1f02-5eed-41ed-c402-540fa50d79f1@haller-berlin.de>
In-Reply-To: <20201014100111.c43f2fqipc52dtsg@yadavpratyush.com>

On 14.10.20 12:01, Pratyush Yadav wrote:
> Hi Stefan,
> 
> On 13/10/20 09:02PM, Stefan Haller wrote:
>> This option is supposed to make a Tcl/Tk app look more like a native app
>> for the respective platform. This doesn't seem to work on Mac, it looks
>> worse than the non-ttk appearance (for instance, the colored pane
>> headers are grey).
> 
> I think we should actually fix the root of the problem instead of just
> fixing the symptoms by disabling ttk.
> 
> There were recently some changes to how git-gui works with ttk in commit
> c02efc1 (git-gui: improve dark mode support, 2020-09-26). Are you
> running git-gui with that commit? If yes, what results do you see with
> it reverted. If no, what results do you see with it applied?

I agree that it would be better to fix the root cause; my suspicion was 
that the themed widgets on Mac simply don't support a background color, 
but I didn't investigate that any further.

I was indeed not running with "git-gui: improve dark mode support" yet, 
but applying it didn't make a difference.

I'm also happy to drop this if you are uncomfortable with it; it's easy 
enough to set gui.usettk to 0 to fix the problem locally.

Best,
Stefan