From: Ramsay Jones <ramsay@ramsayjones.plus.com>
Date: Fri, 04 Mar 2022 20:42:40 GMT
Subject: Re: [PATCH 2/4] terminal: don't assume stdin is /dev/tty
Message-ID: <0a8b4a1d-f6e7-dc8f-3496-c2c96a25bcda@ramsayjones.plus.com>
In-Reply-To: <20220304131126.8293-3-phillip.wood123@gmail.com>



On 04/03/2022 13:11, Phillip Wood wrote:
> From: Phillip Wood <phillip.wood@dunelm.org.uk>
> 
[snip]
> diff --git a/compat/terminal.h b/compat/terminal.h
> index f24b91390d..f5655d0d0b 100644
> --- a/compat/terminal.h
> +++ b/compat/terminal.h
> @@ -3,7 +3,8 @@
>  
>  /* Save input and output settings */
>  #define SAVE_TERM_DUPLEX (1u << 0)
> -
> +/* Save stdin rather than /dev/tty (fails is stdin is not a terminal) */

s/fails is/fails if/ ?

ATB,
Ramsay Jones

> +#define SAVE_TERM_STDIN  (1u << 1)
>  /*
>   * Save the terminal attributes so they can be restored later by a
>   * call to restore_term(). Note that every successful call to