From: Wincent Colaiuta <win@wincent.com>
Date: Fri, 13 Jun 2008 08:43:59 GMT
Subject: Re: [PATCH 2/2] git-gc: skip stashes when expiring reflogs
Message-ID: <0F87000C-B51E-45B8-A21D-1DA184BD603F@wincent.com>
In-Reply-To: <alpine.DEB.1.00.0806130551200.6439@racer>

El 13/6/2008, a las 6:52, Johannes Schindelin escribió:

> Hi,
>
> On Thu, 12 Jun 2008, Eric Raible wrote:
>
>> On Thu, Jun 12, 2008 at 1:51 PM, Junio C Hamano <gitster@pobox.com>  
>> wrote:
>>> Perhaps
>>>
>>> http://thread.gmane.org/gmane.comp.version-control.git/84665/focus=84670
>>>
>>> The user explicitly asks to stash it for a while, where the  
>>> definition of
>>> the "while" comes from reflog's retention period.
>>
>> But that doesn't answer the basic question as to why it's ok
>> to trash data that the user explicitly asked git to save?
>
> If the user really asked git to save the changes, she would have
> _committed_ them.
>
> "git stash" really is only about shelving quickly and dirtily  
> something
> you'll need (or maybe need) in a moment.
>
> If you need something from the stash a day after stashing it, you  
> have a
> serious problem with understanding what branches are for.

While this may be true for codebases which move forward quickly, what  
about one which is basically finished and tends not to get touched in  
a long time. A situation arises, you stash something, the phone rings,  
and for whatever reason the stash gets forgotten and you don't revisit  
the project at all for days, weeks, months. It wouldn't be nice to  
eventually come back and discover that your in-progress work had been  
"garbage" collected for you.

Wincent