From: Wincent Colaiuta <win@wincent.com>
Date: Wed, 18 Feb 2009 10:06:34 GMT
Subject: Re: [PATCH] test suite: correct export var=val usage
Message-ID: <0E74A2BF-1E59-4D82-A750-380697667F10@wincent.com>
In-Reply-To: <1234911457-37188-1-git-send-email-jaysoffian@gmail.com>

El 17/2/2009, a las 23:57, Jay Soffian escribió:

> test_expect_success 'refusing to edit in refs/heads/' '
> 	(MSG=1 GIT_NOTES_REF=refs/heads/bogus &&
> -	 export MSG= GIT_NOTES_REF=refs/heads/bogus &&
> +	export MSG GIT_NOTES_REF &&
> 	 test_must_fail git notes edit)
> '
>
> test_expect_success 'refusing to edit in refs/remotes/' '
> 	(MSG=1 GIT_NOTES_REF=refs/remotes/bogus &&
> -	 export MSG= GIT_NOTES_REF=refs/heads/bogus &&
> +	 export MSG GIT_NOTES_REF &&
> 	 test_must_fail git notes edit)
> '

Perhaps my eyes are playing tricks on me but I see the original  
version setting MSG to an empty string and exporting it, and your  
version setting MSG to "1" and exporting it. So which one is wrong?  
The original or yours?

Cheers,
Wincent