From: Kevin Ballard Date: Tue, 07 Dec 2010 20:31:40 GMT Subject: Re: [PATCH] completion: Add PS1 configuration for submodules Message-ID: <0E479F18-B26A-4216-A71E-C65EAB41A74A@sb.org> In-Reply-To: On Dec 7, 2010, at 4:15 AM, Ævar Arnfjörð Bjarmason wrote: > On Tue, Dec 7, 2010 at 00:22, Scott Kyle wrote: >> For those who often work on repositories with submodules, the dirty >> indicator for unstaged changes will almost always show because development >> is simultaneously happening on those submodules. The config option >> diff.ignoreSubmodules is not appropriate for this use because it has larger >> implications. > > Wouldn't it be a lot better to instead add support for showing > submodule dirtyness as distinct from the main tree's dirtyness? Then > you could easily spot if you had either your tree / submodule tree > changes, without just ignoring them. That sounds like a good idea, but it doesn't necessarily have to come with this patch. Scott's use case here is he has a submodule that is _always_ dirty, and he simply doesn't want to see that stuff in the PS1. Having an option to show it separately would be very useful for me, but should perhaps be written as a separate patch. -Kevin Ballard