From: Philip Oakley Date: Sun, 23 Nov 2014 21:58:48 GMT Subject: Re: Re: [RFC 3/4] engine.pl: split the .o and .obj processing Message-ID: <0DE9992936544B43BD4B7FC2CC4388AD@PhilipOakley> In-Reply-To: From: "Johannes Schindelin" >> > How about the following instead? >> > >> > + } elsif ($part eq 'invalidcontinue.obj') { >> > + # ignore >> > } elsif ($part =~ /\.(o|obj)$/) { >> >> Looks good, I'll use that (after deciding whether .obj files should >> be >> expected in a 'make' output anyway) > > My idea to hardcode invalidcontinue.obj was that I'd rather see a > failure > if an unexpected .obj is seen there. But I realize that my suggested > change does not exactly accomplish that. > I've decided to include the hard code suggested, and after a few tests decided it was probably worth keeping the .obj processing, even though we don't expect any. At least I've now managed to generate a .sln project, though it won't compile because of a number of other changes, and I haven't got to the bottom of them all. Notes: Revert "Windows: correct detection of EISDIR in mingw_open()" git\compat\mingw.c(315) : error C2065: 'O_ACCMODE' : undeclared identifier (neither VS2008 nor VS2010 declare 'O_ACCMODE'). add an #ifdef _MSC_VER to define this if we are in MSVC. Revert "mingw.h: add dummy functions for sigset_t operations" commit 4e6d207c45. the Additional Note: to http://www.spinics.net/lists/git/msg240248.html indicates that this breaks MSVC. I think it will also need an #ifdef to see if we are in MSVC. I've also found a problem with my setup (msysgit 1.7.9 for make) barfing on the commit/ee9be06 "perl: detect new files in MakeMaker builds" which 'make -n' says 'No rule to make target `PM.stamp', needed by `perl.mak'. There was also LINK : warning LNK4098: defaultlib 'MSVCRT' conflicts with use of other libs; use /NODEFAULTLIB:library. I've also got notes from way back that there was build order problem with 'vcs-svn_lib.lib' - probably a sort order issue. IIRC at that time, I had to compile the project twice so that the lib was visible the second time. So there's plenty to go at ;-) I'm going to be away this coming week, So at least I have the whole next cycle to make some progress. -- Philip -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "Git for Windows" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/d/optout.