From: Kristoffer Haugsbakk <kristofferhaugsbakk@fastmail.com>
Date: Tue, 14 Oct 2025 20:43:49 GMT
Subject: Re: [PATCH v4 16/29] sequencer: add trailers to message before writing file
Message-ID: <0995ba92-1feb-4103-b6bd-b792c13a01d2@app.fastmail.com>
In-Reply-To: <20251014122452.1851103-17-me@linux.beauty>

On Tue, Oct 14, 2025, at 14:24, Li Chen wrote:
> Added trailer processing to the in-memory commit message
> within do_pick_commit, ensuring fixup/squash commands
> remain untouched before the message is written.
>
> Signed-off-by: Li Chen <chenl311@chinatelecom.cn>
> ---
>  sequencer.c | 19 ++++++++-----------
>  trailer.c   |  4 ++--
>  trailer.h   |  3 +++
>  3 files changed, 13 insertions(+), 13 deletions(-)
>
> diff --git a/sequencer.c b/sequencer.c
> index 5103ae786c..552e629e4f 100644
> --- a/sequencer.c
> +++ b/sequencer.c
>[snip]
> -static int amend_strbuf_with_trailers(struct strbuf *buf,
> -									  const struct strvec *trailer_args)

Weird indentation.  This looks like it needs clang-format.

> +int amend_strbuf_with_trailers(struct strbuf *buf,
> +       const struct strvec *trailer_args)
>  {
>[snip]