From: Ben Knoble <ben.knoble@gmail.com>
Date: Fri, 25 Sep 2026 20:26:11 GMT
Subject: Re: [PATCH] ci: point leak-sanitizer failures at the actual test and error
Message-ID: <09549A0E-D5FF-465C-A933-F144A19D14E4@gmail.com>
In-Reply-To: <pull.2419.git.git.1790362443893.gitgitgadget@gmail.com>


> Le 25 sept. 2026 à 14:59, Harald Nordgren via GitGitGadget <gitgitgadget@gmail.com> a écrit :
> 
> +finalize_test_leak_output () {
> +    test_leak_summary=$(head -n 40 "$TEST_RESULTS_SAN_FILE".* |
> +        github_escape_message_)
> +    github_annotation_ error "t/$github_markup_script_name" 1 \
> +        "memory leak logged around $this_test.$test_count%0A%0A$test_leak_summary"
> +}
> +
> # No need to override finalize_test_output
> +
> +github_escape_message_ () {
> +    sed -e ':a' -e 'N' -e '$!ba' -e 's/%/%25/g' -e 's/\r/%0D/g' -e 's/\n/%0A/g'
> +}
> +
> +find_test_case_line_ () {
> +    grep -n -F -- "$1" "$TEST_DIRECTORY/$github_markup_script_name" |
> +    head -n 1 | cut -d: -f1
> +}
> +
> +github_annotation_ () {
> +    echo >>$github_markup_output "::$1 file=$2,line=$3::$4"
> +}

Without commenting on the rest, introducing the helpers first might make the important patch easier to read.