From: Derrick Stolee <stolee@gmail.com>
Date: Sun, 30 Nov 2025 19:55:02 GMT
Subject: Re: [PATCH 2/5] scalar: use index.skipHash=true for performance
Message-ID: <089c3225-82cb-4039-83df-f97ea9fd49b2@gmail.com>
In-Reply-To: <xmqqldjsl53m.fsf@gitster.g>

On 11/26/2025 6:57 PM, Junio C Hamano wrote:
> "Derrick Stolee via GitGitGadget" <gitgitgadget@gmail.com> writes:
> 
>> diff --git a/t/t9210-scalar.sh b/t/t9210-scalar.sh
>> index 43c210a23d..91d5964b73 100755
>> --- a/t/t9210-scalar.sh
>> +++ b/t/t9210-scalar.sh
>> @@ -246,6 +246,11 @@ test_expect_success 'scalar reconfigure --all with includeIf.onbranch' '
>>  '
>>  
>>  test_expect_success 'scalar reconfigure --all with detached HEADs' '
>> +	# This test demonstrates an issue with index.skipHash=true and
>> +	# this test variable for the split index. Disable the test variable.
>> +	GIT_TEST_SPLIT_INDEX= &&
>> +	export GIT_TEST_SPLIT_INDEX &&
> 
> Interesting.  I would have expected to see a simple "sane_unset",
> instead of exporting an empty setting explicitly.

That's indeed a better way to do it. Will do in v2.

Thanks,
-Stolee