From: Bagas Sanjaya Date: Fri, 27 Aug 2021 10:46:22 GMT Subject: Re: [PATCH] pretty-options.txt: describe supported encoding Message-ID: <0877bb5d-da4b-125d-7beb-c3138903f468@gmail.com> In-Reply-To: On 27/08/21 04.34, Christopher Yeleighton via GitGitGadget wrote: > From: Christopher Yeleighton > > Please fix the manual for git log. It should say what encoding is recognised > (namely if supported by iconv(1), except that POSIX character maps of > iconv(1p) are not supported), and that an unrecognised encoding is ignored. > > Signed-off-by: > --- The commit message should be: "git log recognizes only system encodings supported by iconv(1), but not POSIX character maps used by iconv(1p). Document it.". > The commit objects record the encoding used for the log message > in their encoding header; this option can be used to tell the > command to re-code the commit log message in the encoding > - preferred by the user. For non plumbing commands this > - defaults to UTF-8. Note that if an object claims to be encoded > - in `X` and we are outputting in `X`, we will output the object > + preferred by the user. > + The encoding must be a system encoding supported by iconv(1), > + otherwise this option will be ignored. > + POSIX character maps used by iconv(1p) are not supported. > + For non-plumbing commands this defaults to UTF-8. > + Note that if an object claims to be encoded in `X` > + and we are outputting in `X`, we shall output the object > verbatim; this means that invalid sequences in the original > commit may be copied to the output. > I think POSIX character maps and encoding are the same, what are their differences? Reading iconv(1p) [1] doesn't give definition of the former. [1]: https://man7.org/linux/man-pages/man1/iconv.1p.html -- An old man doll... just what I always wanted! - Clara