From: Derrick Stolee <stolee@gmail.com>
Date: Thu, 24 Sep 2020 13:51:07 GMT
Subject: Re: [PATCH v3 3/8] maintenance: create auto condition for loose-objects
Message-ID: <07500c68-9fe9-008d-41e7-51a4a1ef4650@gmail.com>
In-Reply-To: <20200922231501.908887-1-jonathantanmy@google.com>

On 9/22/2020 7:15 PM, Jonathan Tan wrote:
>> +test_expect_success 'maintenance.loose-objects.auto' '
>> +	git repack -adk &&
>> +	GIT_TRACE2_EVENT="$(pwd)/trace-lo1.txt" \
>> +		git -c maintenance.loose-objects.auto=1 maintenance \
>> +		run --auto --task=loose-objects 2>/dev/null &&
>> +	test_subcommand ! git prune-packed --quiet <trace-lo1.txt &&
>> +	for i in 1 2
> 
> Any reason why this is run twice?

I think the original reason was to demonstrate how two runs interact,
but then that was done in the middle of the loop body so the loop is
not necessary.

Thanks,
-Stolee