From: Ophir Bleicher Date: Fri, 20 Nov 2026 19:25:16 GMT Subject: Re: [PATCH v2] doc: fix AsciiDoc syntax Message-ID: <072A2362-2FCF-4DC0-8460-86B63498226E@gmail.com> In-Reply-To: OK, thank you! > On 20 Nov 2026, at 21:03, Junio C Hamano wrote: > > "Ophir Bleicher via GitGitGadget" writes: > >> From: Ophir Bleicher >> >> The Documentation/MyFirstContribution.adoc file accidentally used >> Markdown syntax for a link: >> >> [here](https://gitgitgadget.github.io/#...) >> >> Fixed it to use AsciiDoc: >> >> https://gitgitgadget.github.io/#...[here] >> >> Signed-off-by: Ophir Bleicher >> --- > > The exact same tense and mood suggestion applies to this commit > message, too. "uses" and "Fix". I can locally tweak them while > queuing, so no need to resend if you are OK with it. > >> doc: fix AsciiDoc syntax >> >> Difference from v1: >> >> * Change link text >> >> Published-As: https://github.com/gitgitgadget/git/releases/tag/pr-git-2496%2FOphirBleicher%2Fpatch-3-v2 >> Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-git-2496/OphirBleicher/patch-3-v2 >> Pull-Request: https://github.com/git/git/pull/2496 >> >> Range-diff vs v1: >> >> 1: 748ac69283 ! 1: cf26060e59 doc: fix AsciiDoc syntax >> @@ Documentation/MyFirstContribution.adoc: either with the "New pull request" butto >> >> The differences between using `gitgitgadget/git` and `git/git` as your base can >> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror) >> -+be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[here] >> ++be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.] >> >> Review the PR's title and description, as they're used by GitGitGadget >> respectively as the subject and body of the cover letter for your change. Refer >> >> >> Documentation/MyFirstContribution.adoc | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/Documentation/MyFirstContribution.adoc b/Documentation/MyFirstContribution.adoc >> index c58253fd54..73dab5f7c9 100644 >> --- a/Documentation/MyFirstContribution.adoc >> +++ b/Documentation/MyFirstContribution.adoc >> @@ -931,7 +931,7 @@ either with the "New pull request" button or the convenient "Compare & pull >> request" button that may appear with the name of your newly pushed branch. >> >> The differences between using `gitgitgadget/git` and `git/git` as your base can >> -be found [here](https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror) >> +be found https://gitgitgadget.github.io/#should-i-use-gitgitgadget-on-gitgitgadgets-git-fork-or-on-gits-github-mirror[on GitGitGadget's official documentation.] >> >> Review the PR's title and description, as they're used by GitGitGadget >> respectively as the subject and body of the cover letter for your change. Refer >> >> base-commit: f7de81456940dd6f3274e461149bba12965de609